Reply To: Issue migrating from PrettyFaces 3.3.3 to Rewrite 2.0.2.

Splash Forums PrettyFaces Users Issue migrating from PrettyFaces 3.3.3 to Rewrite 2.0.2. Reply To: Issue migrating from PrettyFaces 3.3.3 to Rewrite 2.0.2.

#24279

Thank you! I love writing OSS 🙂

And yeah, I think that you are probably right that ordering is part of the issue, but in reality I don’t think that Query params should be matched or generated as part of the URL path; so, separating the logic for this might be a good idea to prevent ordering issues, as you suggested.

I appreciate you taking a look! If you want an idea of how to get started, I would probably take one of the existing tests in the rewrite-config-prettyfaces-tests module (from github – https://github.com/ocpsoft/rewrite/tree/master/config-prettyfaces-tests), copy it, rename it to something that relates to this problem, and write a test that verifies the failure.

Once you have that failing test, start writing the functionality to fix it. This will be beneficial because we can ensure that the problem never occurs again, and also if you have issues, I can easily reproduce the problem by running your test case and help out 🙂

Thanks again!
~Lincoln