Re: Regex-based exception encountered with dynaview in PrettyFaces 3/4

Splash Forums PrettyFaces Users Regex-based exception encountered with dynaview in PrettyFaces 3/4 Re: Regex-based exception encountered with dynaview in PrettyFaces 3/4

#21445

Hey all,

I just had a deeper look at this issue. In fact it has nothing to do with dynaview. The reason it also appears for dynaviews is that every dynaview request runs a second time through the filter (with shouldProcessDynaview() returning false).

I was able to reproduce this issue with a simple mapping like this:

<url-mapping id="test">
<pattern value="/page" />
<view-id value="/unusual-view-id-(.xhtml" />
</url-mapping>

I added this as an Arquillian test to our test suite.

As you see the view-id is not a valid regular expression, but a valid view-id. The old code in PrettyFilter and UrlMappingRuleAdaptor failed for this mapping. But after changing matches() to equals() everything works fine.

I just pushed the fix upstream. So this shouldn’t be an issue any more.