Re: Arquillian tests and pull request for performance improvements

Splash Forums PrettyFaces Users Arquillian tests and pull request for performance improvements Re: Arquillian tests and pull request for performance improvements

#21646

Hey Frank,

the Arquillian tests should work out of the box. Do you get an error? On my box individual tests sometimes fail without any reason but succeed when I run the test again. I’m not sure what the issue is. Could you post your error?

I saw you pull request. Thanks for creating it. However I think the patch introduces some bugs. I for example saw that you replaced the URL encoding based on java.net.URI with URLDecoder/URLEncoder. This is definitively wrong. We did this in the past and it was incorrect because these classes are not meant to be used for URL but for FORM data encoding/decoding.

I’ll take a deeper look at your patch as soon as I find some time. But I’m travelling next week so this could take some time.

Best regards

Christian