Re: Arquillian tests and pull request for performance improvements

Splash Forums PrettyFaces Users Arquillian tests and pull request for performance improvements Re: Arquillian tests and pull request for performance improvements

#21653

Frank Caputo
Participant

Hi,

sorry for answering that late. I’m quite busy currently.

I think a MappingCacheProvider is nice, but a little bit too heavy. A simple LRU cache with a configurable size should suite all fits. You should also have the option to disable caching completely.

I think caching is essential, because PrettyFaces is made for SEO and good SEO results in high traffic.

I wonder why HttpServletRequest.isRequestedSessionIdFromURL() doesn’t work as expected. Regular expressions are slow, especially, when they are reconstructed on every use instead of simply reusing them (java.util.regex.Pattern is thread safe). This is why I tried to eleminate them.

I will have a look at HttpServletRequest.isRequestedSessionIdFromURL() and the URLEncoder thing later.

Ciao Frank